This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Refactor DdlImports - System.Reflection.Metadata #40579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madmir
force-pushed
the
DllImports-SystemReflectionMetadata
branch
5 times, most recently
from
828fe07
to
dae38fb
Compare
stephentoub
reviewed
Sep 4, 2019
src/Common/src/Interop/Windows/Kernel32/Interop.ReadFile_Bool_SafeHandle_IntPtr.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Sep 4, 2019
src/System.Reflection.Metadata/tests/System.Reflection.Metadata.Tests.csproj
Outdated
Show resolved
Hide resolved
|
@tmat @nguerrera I assigned you as reviewer since it seems to be for System.Reflection.Metadata area. The PR looks to be ready for review. |
stephentoub
force-pushed
the
DllImports-SystemReflectionMetadata
branch
from
ab6778e
to
4ea838b
Compare
stephentoub
force-pushed
the
DllImports-SystemReflectionMetadata
branch
from
4ea838b
to
cb98973
Compare
stephentoub
approved these changes
Oct 21, 2019
safern
approved these changes
Oct 21, 2019
|
Test failures are known issue: https://github.com/dotnet/coreclr/issues/27305 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #33774
Note that since test project has DllImports as well, CS0436 warnings (type (Interop) conflicts with imported type) were disabled.
cc: @stephentoub